Skip to content

bpo-40196: Fix a bug in the symtable when reporting inspecting global variables#19391

Merged
pablogsal merged 2 commits into
python:masterfrom
pablogsal:bpo-40196
Apr 6, 2020
Merged

bpo-40196: Fix a bug in the symtable when reporting inspecting global variables#19391
pablogsal merged 2 commits into
python:masterfrom
pablogsal:bpo-40196

Conversation

@pablogsal

@pablogsal pablogsal commented Apr 6, 2020 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

corona10
corona10 reviewed Apr 6, 2020
View reviewed changes
Comment thread Misc/NEWS.d/next/Library/2020-04-06-11-05-13.bpo-40196.Jqowse.rst Outdated
@@ -0,0 +1,2 @@
Fix a bug in the ``symtable`` module that was causing incorrectly report

@corona10 corona10 Apr 6, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit

:mod:`symtable`

@pablogsal pablogsal Apr 6, 2020

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I was under the impression that both produce the same sphinx output?

@corona10 corona10 Apr 6, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, it generates different output, The latter creates a hyperlink to the module

``symtable``

스크린샷 2020-04-07 오전 12 04 52

:mod:`symtable`

스크린샷 2020-04-07 오전 12 04 10

@corona10 corona10 Apr 6, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So end-user can move to the module more easily :)

@pablogsal pablogsal Apr 6, 2020

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, I have been living in a lie! Thanks for pointing this out :)

pablogsal
pablogsal commented Apr 6, 2020
View reviewed changes
Comment thread Misc/NEWS.d/next/Library/2020-04-06-11-05-13.bpo-40196.Jqowse.rst Outdated
@pablogsal pablogsal merged commit 799d7d6 into python:master Apr 6, 2020
@pablogsal pablogsal deleted the bpo-40196 branch April 6, 2020 16:06
@miss-islington

miss-islington commented Apr 6, 2020

Copy link
Copy Markdown
Contributor

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@miss-islington

miss-islington commented Apr 6, 2020

Copy link
Copy Markdown
Contributor

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 6, 2020
@pablogsal @miss-islington
bpo-40196: Fix a bug in the symtable when reporting inspecting global…
ea33491 
… variables (pythonGH-19391)

(cherry picked from commit 799d7d6)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
@bedevere-bot

bedevere-bot commented Apr 6, 2020

Copy link
Copy Markdown

GH-19394 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 6, 2020
@pablogsal @miss-islington
bpo-40196: Fix a bug in the symtable when reporting inspecting global…
d54a0ae 
… variables (pythonGH-19391)

(cherry picked from commit 799d7d6)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
@bedevere-bot

bedevere-bot commented Apr 6, 2020

Copy link
Copy Markdown

GH-19395 is a backport of this pull request to the 3.7 branch.

miss-islington added a commit that referenced this pull request Apr 6, 2020
@miss-islington @pablogsal
bpo-40196: Fix a bug in the symtable when reporting inspecting global…
717f166 
… variables (GH-19391)

(cherry picked from commit 799d7d6)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
pablogsal added a commit that referenced this pull request Apr 6, 2020
@miss-islington @pablogsal
bpo-40196: Fix a bug in the symtable when reporting inspecting global…
8bd84e7 
… variables (GH-19391) (GH-19394)

(cherry picked from commit 799d7d6)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
@bedevere-bot

bedevere-bot commented Apr 6, 2020

Copy link
Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 FreeBSD Shared 3.x has failed when building commit 799d7d6.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/152/builds/541) and take a look at the build logs.
  4. Check if the failure is related to this commit (799d7d6) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/152/builds/541

Failed tests:

  • test_multiprocessing_fork
  • test_capi
  • test_multiprocessing_spawn
  • test_zipfile
  • test_lzma
  • test_itertools
  • test_compile
  • test_concurrent_futures
  • test_unicode
  • test_pickle
  • test_lib2to3
  • test_shutil
  • test_distutils
  • test_tokenize
  • test__xxsubinterpreters
  • test_unparse
  • test_multiprocessing_forkserver

Failed subtests:

  • test_subinterpreter - test.test__xxsubinterpreters.IsRunningTests

Summary of the results of the build (if available):

==

Click to see traceback logs 
Traceback (most recent call last):
  File "/usr/home/buildbot/python/3.x.koobs-freebsd-564d/build/Lib/test/test__xxsubinterpreters.py", line 492, in test_subinterpreter
    self.assertTrue(interpreters.is_running(interp))
AssertionError: False is not true

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@corona10 corona10 corona10 left review comments
@isidentical isidentical isidentical approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@pablogsal @miss-islington @bedevere-bot @corona10 @isidentical @the-knights-who-say-ni